Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go:mod: runtime-spec v1.1.0-rc.1; add docs/spec-conformance.md #3716

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Feb 1, 2023

runc now implements the OCI Runtime Spec v1.1.0-rc.1 for the linux platform.

The following features are not implemented yet:

Spec version Feature PR
v1.0.0 SCMP_ARCH_PARISC Unplanned, due to lack of users
v1.0.0 SCMP_ARCH_PARISC64 Unplanned, due to lack of users
v1.0.2 .linux.personality #3126
v1.1.0-rc.1 .linux.resources.cpu.burst #3205
v1.1.0-rc.1 .domainname #3600
v1.1.0-rc.1 .[]mounts.uidMappings #3717
v1.1.0-rc.1 .[]mounts.gidMappings #3717
v1.1.0-rc.1 SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV TODO

@AkihiroSuda
Copy link
Member Author

Let's release runc v1.2.0-rc.1 after merging this
@opencontainers/runc-maintainers

@kolyshkin kolyshkin added this to the 1.2.0 milestone Feb 1, 2023
kolyshkin
kolyshkin previously approved these changes Feb 1, 2023
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda
Copy link
Member Author

Rebased, as #3377 was merged

docs/spec-conformance.md Outdated Show resolved Hide resolved
@AkihiroSuda AkihiroSuda force-pushed the spec-v1.1.0-rc.1 branch 2 times, most recently from 7724eb0 to d1127d9 Compare February 1, 2023 12:37
thaJeztah
thaJeztah previously approved these changes Feb 1, 2023
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda
Copy link
Member Author

Rebased

@AkihiroSuda
Copy link
Member Author

Rerebased

@kolyshkin
Copy link
Contributor

kolyshkin commented Feb 10, 2023

Failure in centos-stream-9 CI:

=== RUN   TestPodSkipDevicesUpdate
    systemd_test.go:114: container stderr not empty: /bin/basename: missing operand
        Try '/bin/basename --help' for more information.
--- FAIL: TestPodSkipDevicesUpdate (0.14s)

Hmm, I have absolutely no idea where the "basename" is coming from in this test. Most probably it's from some bashrc on the testing host (in this case we run bash from the host inside the cgroup, see

cmd := exec.Command("bash", "-c", "read; echo > /dev/full; cat /dev/null; true")
). We can maybe add --norc to work around this, but in general this should not ever happen.

Update: ah, this is centos-stream-9, perhaps something was broken in there.

@AkihiroSuda
Copy link
Member Author

Restarted the CI and it is now green

@rata
Copy link
Member

rata commented Feb 10, 2023

Update: ah, this is centos-stream-9, perhaps something was broken in there.

I've seen this error yesterday too :-/ I completely forgot about it.

@AkihiroSuda
Copy link
Member Author

@kolyshkin @thaJeztah Lost your LGTMs after rebasing, could you LGTM again 🙏

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still LGTM

@AkihiroSuda AkihiroSuda merged commit 7d4fde2 into opencontainers:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants