Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid leaking memory #105

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Avoid leaking memory #105

merged 3 commits into from
Aug 7, 2024

Conversation

Midnighter
Copy link
Member

Fix #31

Many thanks to @stanleybak for suggesting the fix and apologies for taking so long to implement it.

Implement more validation steps.
@Midnighter Midnighter requested a review from cdiener August 7, 2024 15:36
@Midnighter Midnighter self-assigned this Aug 7, 2024
@cdiener
Copy link
Member

cdiener commented Aug 7, 2024

Some of the C API functions have been deprecated. Should probably be PyObject_Call instead of the PyEval calls.

@Midnighter Midnighter merged commit 234c338 into master Aug 7, 2024
5 checks passed
@Midnighter Midnighter deleted the fix-leak branch August 7, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

memory allocated with as_intArray and as_doubleArray is never freed
2 participants