Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK-7134 - Re-implement Aggregations Stats for all Catalog Browsers #2529

Open
wants to merge 24 commits into
base: develop
Choose a base branch
from

Conversation

jtarraga
Copy link
Member

Re-implement Aggregations Stats for all Catalog Browsers

@jtarraga jtarraga requested a review from pfurio November 12, 2024 10:17
@halender
Copy link
Contributor

@Path("/aggregationStats")
@ApiOperation(value = "Fetch catalog cohort stats", response = FacetField.class)
public Response getAggregationStats(
@ApiParam(value = ParamConstants.STUDY_DESCRIPTION)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These fields need to be the same ones we have in the /search and /distinct web service. 'creationYear', 'creationMonth', etc were past fields that we allowed when this was implemented with Solr but not anymore.

@Path("/aggregationStats")
@ApiOperation(value = "Fetch catalog family stats", response = FacetField.class)
public Response getAggregationStats(
@ApiParam(value = ParamConstants.STUDY_DESCRIPTION)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. We should add the fields we currently have in the /search and /distinct web services

@Path("/aggregationStats")
@ApiOperation(value = "Fetch catalog file stats", response = FacetField.class)
public Response getAggregationStats(
@ApiParam(value = ParamConstants.STUDY_DESCRIPTION)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. We should add the fields we currently have in the /search and /distinct web services

@Path("/aggregationStats")
@ApiOperation(value = "Fetch catalog individual stats", response = FacetField.class)
public Response getAggregationStats(
@ApiParam(value = ParamConstants.STUDY_DESCRIPTION)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. We should add the fields we currently have in the /search and /distinct web services

@Path("/aggregationStats")
@ApiOperation(value = "Fetch catalog job stats", response = FacetField.class)
public Response getAggregationStats(
@ApiParam(value = ParamConstants.STUDY_DESCRIPTION) @QueryParam(ParamConstants.STUDY_PARAM) String studyStr,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. We should add the fields we currently have in the /search and /distinct web services

@Path("/aggregationStats")
@ApiOperation(value = "Fetch catalog panel stats", response = FacetField.class)
public Response getAggregationStats(
@ApiParam(value = ParamConstants.STUDY_DESCRIPTION) @QueryParam(ParamConstants.STUDY_PARAM) String studyStr,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. We should add the fields we currently have in the /search and /distinct web services

@Path("/aggregationStats")
@ApiOperation(value = "Fetch catalog sample stats", response = FacetField.class)
public Response getAggregationStats(
@ApiParam(value = ParamConstants.STUDY_DESCRIPTION) @QueryParam(ParamConstants.STUDY_PARAM) String studyStr,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. We should add the fields we currently have in the /search and /distinct web services

@jtarraga jtarraga requested a review from pfurio November 13, 2024 12:15
@jtarraga jtarraga changed the title Task 7134 - Re-implement Aggregations Stats for all Catalog Browsers TASK-7134 - Re-implement Aggregations Stats for all Catalog Browsers Nov 13, 2024
pfurio
pfurio previously approved these changes Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants