-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TASK-7134 - Re-implement Aggregations Stats for all Catalog Browsers #2529
base: develop
Are you sure you want to change the base?
Conversation
…ats endpoint, generate clients, #TASK-7152, #TASK-7134
…, #TASK-7152, #TASK-7134
…s, families, individuals, interpretations, jobs and panels, #TASK-7152, #TASK-7134
…rpretations, #TASK-7152, #TASK-7134
…n, #TASK-7152, #TASK-7134
@Path("/aggregationStats") | ||
@ApiOperation(value = "Fetch catalog cohort stats", response = FacetField.class) | ||
public Response getAggregationStats( | ||
@ApiParam(value = ParamConstants.STUDY_DESCRIPTION) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These fields need to be the same ones we have in the /search and /distinct web service. 'creationYear', 'creationMonth', etc were past fields that we allowed when this was implemented with Solr but not anymore.
@Path("/aggregationStats") | ||
@ApiOperation(value = "Fetch catalog family stats", response = FacetField.class) | ||
public Response getAggregationStats( | ||
@ApiParam(value = ParamConstants.STUDY_DESCRIPTION) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. We should add the fields we currently have in the /search and /distinct web services
@Path("/aggregationStats") | ||
@ApiOperation(value = "Fetch catalog file stats", response = FacetField.class) | ||
public Response getAggregationStats( | ||
@ApiParam(value = ParamConstants.STUDY_DESCRIPTION) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. We should add the fields we currently have in the /search and /distinct web services
@Path("/aggregationStats") | ||
@ApiOperation(value = "Fetch catalog individual stats", response = FacetField.class) | ||
public Response getAggregationStats( | ||
@ApiParam(value = ParamConstants.STUDY_DESCRIPTION) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. We should add the fields we currently have in the /search and /distinct web services
@Path("/aggregationStats") | ||
@ApiOperation(value = "Fetch catalog job stats", response = FacetField.class) | ||
public Response getAggregationStats( | ||
@ApiParam(value = ParamConstants.STUDY_DESCRIPTION) @QueryParam(ParamConstants.STUDY_PARAM) String studyStr, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. We should add the fields we currently have in the /search and /distinct web services
@Path("/aggregationStats") | ||
@ApiOperation(value = "Fetch catalog panel stats", response = FacetField.class) | ||
public Response getAggregationStats( | ||
@ApiParam(value = ParamConstants.STUDY_DESCRIPTION) @QueryParam(ParamConstants.STUDY_PARAM) String studyStr, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. We should add the fields we currently have in the /search and /distinct web services
@Path("/aggregationStats") | ||
@ApiOperation(value = "Fetch catalog sample stats", response = FacetField.class) | ||
public Response getAggregationStats( | ||
@ApiParam(value = ParamConstants.STUDY_DESCRIPTION) @QueryParam(ParamConstants.STUDY_PARAM) String studyStr, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. We should add the fields we currently have in the /search and /distinct web services
Re-implement Aggregations Stats for all Catalog Browsers