Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: brings back --make-paths-enum option to generate ApiPaths enum #2052

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

laurenz-glueck
Copy link

@laurenz-glueck laurenz-glueck commented Dec 14, 2024

Changes

Brings back --make-paths-enum option to generate ApiPaths enum.
See: #1057

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

Copy link

changeset-bot bot commented Dec 14, 2024

⚠️ No Changeset found

Latest commit: aeb2f5b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@laurenz-glueck laurenz-glueck marked this pull request as ready for review December 20, 2024 08:44
@laurenz-glueck laurenz-glueck requested a review from a team as a code owner December 20, 2024 08:44
@laurenz-glueck laurenz-glueck requested a review from gzm0 December 20, 2024 08:44
@gzm0
Copy link
Contributor

gzm0 commented Dec 20, 2024

@drwpow it seems you have some more context on this.

I suspect the discussion in the issue went missing because it was closed.

@drwpow
Copy link
Contributor

drwpow commented Dec 21, 2024

Sorry I think this was just an accidental omission for 7.x, but since it’s an opt-in feature flag I support adding it! (I’ll only try to ensure that default behavior doesn’t change).

I’m in favor of this merging, but we’ll need to add a few tests just to ensure this feature doesn’t break. Also please add a minor changeset for this feature so we can release it 🙏

@laurenz-glueck
Copy link
Author

@drwpow Sounds good!
Please give me a few days and I will try to add some tests and also the changeset…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants