You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
@drwpow something like this is what I have been thinking. Of course it will not validate the regexes, but it will at least generate a union type that represents the schema.
Yeah this is a tricky one but I’m open to adding whatever support we can here. Better than simply ignoring it altogether. I’m in favor of this approach as it shouldn’t break backwards compatibility for most folks
Sorry—just realized I went a while without checking in on this. I’m happy with the direction of this PR, and we’ve discussed a lot of things outside of here 🙂. If we just add a couple tests for this I think this direction is good to ship!
openapi-tsRelevant to the openapi-typescript library
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gzm0
force-pushed
the
pattern-properties
branch
from
Changes
Add support for
patternPropertiesin addition toadditionalProperties(#754).How to Review
Overall approach so far only.
Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)