fix: Fix multipart body file array #938
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micha91
force-pushed
the
fix-multipart-body-file-array
branch
from
651fddc
to
fe841d7
Compare
micha91
changed the title
|
Thanks for adding this support! I believe this is a breaking change, since it's possible someone was using the JSON serialization behavior before (even though it seems wrong in general). I'll need to do some manual testing just to make sure I know how to describe the breaking change 😅. I'd also love to get someone to test a real running API and verify it all functions (maybe you've already done this?) |
|
Yes, I already use the updated model template as a custom template in a project. Unfortunately this project is not public yet and the API it is developed for, isn't publicly accessible, too |
|
Hi, just tested this out with an api I am working on. It works great. |
# Conflicts: # end_to_end_tests/golden-record/my_test_api_client/models/model_with_additional_properties_refed.py # end_to_end_tests/golden-record/my_test_api_client/models/model_with_any_json_properties.py # end_to_end_tests/golden-record/my_test_api_client/models/model_with_circular_ref_in_additional_properties_a.py # end_to_end_tests/golden-record/my_test_api_client/models/model_with_circular_ref_in_additional_properties_b.py # end_to_end_tests/golden-record/my_test_api_client/models/model_with_primitive_additional_properties_a_date_holder.py # end_to_end_tests/golden-record/my_test_api_client/models/model_with_recursive_ref_in_additional_properties.py # openapi_python_client/templates/model.py.jinja
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #692 arrays of files are not handled correctly, if they are part of multipart/form-data. This is fixed in this PR by letting
to_multipartreturn aList[Tuple[str, Any]]instead of aDict[str, Any].