(BUGFIX) Use labels in generate_functions #1056
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottrblock
changed the title
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The existing code has
"r'^(?:' + '|'.join({labels}) + ')$'", which is presumably trying to join the labels passed into the function, but the string interpolation does not appear to be correct python. It's not clear to me how important "correctness" is in these functions, but it seems like it would all work better if it was valid python.My change uses
pattern = r'^(?:' + '|'.join(labels.keys()) + ')$'\n",Motivation
I was looking into how to use functions API and realized there appeared to be a bug in the cookbook example.