Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor join arrayops and intidx internals #204

Merged
merged 1 commit into from
May 25, 2024

Conversation

nvictus
Copy link
Member

@nvictus nvictus commented Apr 27, 2024

This PR is attempting to simplify the logic and harmonize the internals of overlap and closest at all three layers (internal array function, internal intidx function, and public function):

  • Change the low-level representation of the join output from a single (n, 2) array of indices to two (n,) arrays. This turns out to involve less intermediate manipulation and leads to more readable code.
  • Streamline join type handling (left, right, outer) and better align overlap and closest implementation details.

@nvictus nvictus requested review from agalitsyna and alejandrogzi and removed request for agalitsyna May 20, 2024 19:05
@nvictus nvictus merged commit 755abd5 into open2c:main May 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants