Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IA] Relocate Java Automatic pages to new Zero-code section #4430

Merged
merged 8 commits into from
May 23, 2024
Merged

[IA] Relocate Java Automatic pages to new Zero-code section #4430

merged 8 commits into from
May 23, 2024

Conversation

chalin
Copy link
Contributor

@chalin chalin commented May 6, 2024 •
edited

@svrnm @zeitlinger et all:

  • Is this what we had envisioned?
  • Should App server config, currently under the Java Agent section, be moved up one level?

Screenshots

The new left-nav:

@chalin chalin requested review from a team as code owners May 6, 2024 19:55
@chalin chalin added the IA Information architecture rework label May 6, 2024
@zeitlinger
Copy link
Member

looks great - I'm double checking with the Java SIG to be sure

svrnm
svrnm requested changes May 7, 2024
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for driving this! There are still a few places with "manual/automatic" which we should consider replacing with "code-based" and "zero-code" but I think that's one of the many follow ups we need to do

content/en/docs/zero-code/_index.md Outdated Show resolved Hide resolved
content/en/docs/zero-code/_index.md Outdated Show resolved Hide resolved
content/en/docs/zero-code/java/_index.md Outdated Show resolved Hide resolved
content/en/docs/zero-code/java/agent/_index.md Outdated Show resolved Hide resolved
@chalin chalin force-pushed the chalin-im-zero-code-for-java-2024-05-06 branch 2 times, most recently from 962cff6 to ee2154f Compare May 7, 2024 08:51
@chalin chalin requested a review from svrnm May 7, 2024 08:52
@chalin
Copy link
Contributor Author

chalin commented May 7, 2024

I reapplied your suggested changes because I overwrote them by mistake. PTAL @svrnm

svrnm
svrnm approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@svrnm svrnm added sig:java sig-approval-missing Co-owning SIG didn't provide an approval labels May 8, 2024
@svrnm
Copy link
Member

svrnm commented May 8, 2024

@open-telemetry/java-approvers @open-telemetry/java-instrumentation-approvers PTAL!

@chalin chalin force-pushed the chalin-im-zero-code-for-java-2024-05-06 branch from ee2154f to 6671fd2 Compare May 8, 2024 09:00
cartermp
cartermp approved these changes May 8, 2024
View reviewed changes
content/en/docs/zero-code/_index.md Outdated Show resolved Hide resolved
@chalin chalin force-pushed the chalin-im-zero-code-for-java-2024-05-06 branch from 0facfef to dcd529a Compare May 8, 2024 17:41
zeitlinger
zeitlinger reviewed May 23, 2024
View reviewed changes
content/en/docs/zero-code/java/_index.md Outdated Show resolved Hide resolved
content/en/docs/zero-code/java/_index.md Outdated Show resolved Hide resolved
@zeitlinger
Copy link
Member

I think we need redirects from the old pages

@svrnm
Copy link
Member

svrnm commented May 23, 2024

I think we need redirects from the old pages

From what I see in the code @chalin took care of that, any specific redirects you are missing?

@zeitlinger
Copy link
Member

I think we need redirects from the old pages

From what I see in the code @chalin took care of that, any specific redirects you are missing?

no, just missed it...

@svrnm svrnm requested a review from zeitlinger May 23, 2024 11:00
@cartermp
Copy link
Contributor

@chalin unfortunately it seems there are some conflicts now

@svrnm
Copy link
Member

svrnm commented May 23, 2024

@chalin unfortunately it seems there are some conflicts now

@chalin is out of office this week as far as I know, I can take a look

@svrnm svrnm merged commit 9eab7c5 into open-telemetry:main May 23, 2024
15 checks passed
@zeitlinger zeitlinger mentioned this pull request May 2, 2024
Closed
@zeitlinger
Copy link
Member

thanks a lot for the help!

@jaydeluca jaydeluca mentioned this pull request May 24, 2024
Merged
@chalin chalin deleted the chalin-im-zero-code-for-java-2024-05-06 branch May 27, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svrnm svrnm svrnm approved these changes

@theletterf theletterf theletterf approved these changes

@zeitlinger zeitlinger zeitlinger approved these changes

@cartermp cartermp cartermp approved these changes

Assignees
No one assigned
Labels
IA Information architecture rework sig:java sig-approval-missing Co-owning SIG didn't provide an approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chalin @zeitlinger @svrnm @cartermp @theletterf