Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Otlp http exporter client cert #3883

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

xman1979
Copy link

@xman1979 xman1979 commented Apr 26, 2024

Description

Allow to pass a client certificate to the OTLPLogExporter
In our environment, the server needs to authenticate the client, in this PR, it simply forward the client certificate to the requests.post()

Did not hookup with environment variables yet, open the discussion here and we can add later
#3882 (comment)

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

This test requires the server setup to authenticate the client certificate

  • [X ] Test A
  1. Start the otel server to set required client certificate true
  2. Create a client to pass the client certificate,
    exporter = OTLPLogExporter(
                endpoint=f"https://{endpoint}/v1/logs",
                timeout=5,
                certificate_file="/etc/pki/tls/certs/ca-bundle.crt",
                client_certificate_file="/etc/nobody.pem"
            )
  1. Check the client certificate can be properly authenticated.

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xman1979 xman1979 requested a review from a team as a code owner April 26, 2024 18:42
Copy link

linux-foundation-easycla bot commented Apr 26, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, if we want to add this we'll need some tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants