Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize _load_runtime_context #3782

Closed
wants to merge 1 commit into from
Closed

Conversation

Chise1
Copy link

@Chise1 Chise1 commented Mar 14, 2024

Description

reduce threading lock.Look code.

Fixes #3781

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

My first submission, please let me know if I made a mistake.

@Chise1 Chise1 requested a review from a team as a code owner March 14, 2024 12:34
Copy link

linux-foundation-easycla bot commented Mar 14, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@xrmx
Copy link
Contributor

xrmx commented Mar 14, 2024

Have you seen #3763?

@pmcollins
Copy link
Member

Have you seen #3763?

Yes, they have -- they closed the issue 🙂.

#3781

@Chise1 Chise1 closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce the _load_runtime_context call lock
3 participants