feat(sdk-trace-node): add env mapping for xray-lambda propagator #4685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
I am closing this since the lambda propagator is experimental. I am planning to open an alternative PR to add the mapping to the (experimental) Node SDK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #4494
This is a follow-up to #4554 and similar update to #4602. It adds mapping of
xray-lambdain the OTEL_PROPAGATORS env variable to the Xray Lambda propagator.NOTE: Based on discussion in #4602, I think this mapping should be in this package. However, the Xray Lambda propagator is currently in the experimental section. I am not sure if this stable package can have a dependency on an experimental package.