feat(instrumentation)!: simplify registerInstrumentations()
API
#4675
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@opentelemetry/instrumentation
package exports aInstrumentationOption
type:However,
InstrumentationBase
implementsInstrumentation
already. Further, this requires extra code to make whats passed toinstrumentations
just slightly more convenient, for instance it supports:registerInstrumentations({instrumentations: fooInstrumentation})
registerInstrumentations({instrumentations: [fooInstrumentation, [barInstrumentation]]})
This PR proposes removing this
InstrumentationOption
type, and replacing all usages ofInstrumentationOption
andInstrumentationOption[]
with(Instrumentation | Insturmentation[])[]
. This drops support for the first case listed above in favor of always having to provide a list of instrumentations. This simplifies the code in bothsdk-node
andinstrumentation
.