Add grpc sent event before sending the message #11413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitlinger
approved these changes
May 23, 2024
trask
reviewed
May 23, 2024
| Span span = Span.fromContext(context); | ||
| Attributes attributes = | ||
| Attributes.of(MESSAGE_TYPE, SENT, MESSAGE_ID, MESSAGE_ID_UPDATER.incrementAndGet(this)); | ||
| span.addEvent("message", attributes); |
There was a problem hiding this comment.
I'm thinking (guessing) that it's better to only emit the event when the message is successfully sent (or if we're going to emit it when it fails to note the failure somehow in the event that is emitted)
I think it's fine to loosen the assertion ordering constraint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes https://ge.opentelemetry.io/s/vs6vvuevyrcss/tests/task/:instrumentation:grpc-1.6:library:test/details/io.opentelemetry.instrumentation.grpc.v1_6.GrpcStreamingTest/conversation(int%2C%20int)%5B9%5D?top-execution=1
Currently it is possible that
RECEIVEDevent appears beforeSENTevent. Alternatively we could rework the assertion so that it would not fail when the order of the events is swapped. These events were introduced in #4098 @trask do you review whether moving adding the event beforesendMessageis ok.