Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add coverage #10946

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Conversation

robberphex
Copy link
Contributor

  1. add jacoco to modules
  2. upload jacoco reports to codecov

#1555

@robberphex robberphex requested a review from a team March 24, 2024 03:35
@robberphex
Copy link
Contributor Author

This PR is work in progress, and if there is any problem, please feedback here.

@robberphex
Copy link
Contributor Author

@@ -302,6 +302,7 @@ jobs:
**/jitdump.*.dmp
if-no-files-found: ignore

<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line caused CI running failed, for detail you can refer to https://github.com/open-telemetry/opentelemetry-java-instrumentation/actions/runs/8406624268

@laurit
Copy link
Contributor

laurit commented Mar 25, 2024

Firstly see https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/conventions/src/main/kotlin/otel.jacoco-conventions.gradle.kts Currently we apply the jacoco conventions only to library instrumentations and sdk extensions, you also added it to some javaagent modules, does it actually report meaningful results for these?

@robberphex
Copy link
Contributor Author

@laurit I noticed otel.jacoco-conventions.gradle.
There's no need to add jacoco again. I am trying to figure out how to aggregate coverage reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants