[collector] Allow more flexibility around adding volumes/volumeMounts #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunter0
requested review from
dmitryax,
TylerHelmuth and
povilasv
as code owners
|
@chunter0 please on an issue where we can discuss in depth the problem you're experiencing and how this PR solves it. |
JaredTan95
reviewed
Apr 19, 2024
| @@ -230,7 +230,9 @@ priorityClassName: "" | |||
|
|
|||
| extraEnvs: [] | |||
| extraEnvsFrom: [] | |||
| volumes: [] | |||
There was a problem hiding this comment.
Why do we need repeated volumes when we already have extraVolumes?
| extraVolumes: [] | ||
| volumeMounts: [] |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
I opened #1168 for discussion |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes included here add more flexibilitly to opentelemetry-collector deployments when being consumed as a subchart. Having both
volumes/volumeMountsandextraVolumes/extraVolumeMountsallows the owner of the subchart a space to add pre-defined volumes/volumeMounts. Giving the consumer the freedom to add more volumes/volumeMounts under extraVolumes/extraVolumeMounts fields.