Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk/instrumentation: Fix Library type deprecation #5628

Closed
wants to merge 1 commit into from

Conversation

pellared
Copy link
Member

Properly create a "Deprecated:" paragraph.

Before (https://pkg.go.dev/go.opentelemetry.io/otel/sdk/instrumentation#Library):

image

After:

image

image

@pellared pellared added documentation Provides helpful information pkg:SDK Related to an SDK package Skip Changelog PRs that do not require a CHANGELOG.md entry labels Jul 17, 2024
@pellared
Copy link
Member Author

Error: internal/otlptracetest/data.go:49:28: SA1019: instrumentation.Library is deprecated: use [Scope] instead. (staticcheck)
InstrumentationLibrary: instrumentation.Library{

Blocked (or simply conflicting) with #5627 (review)

@pellared pellared marked this pull request as draft July 17, 2024 14:10
@dmathieu
Copy link
Member

The commit in this PR is now cherry-picked into #5627.

@pellared pellared closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Provides helpful information pkg:SDK Related to an SDK package Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants