allow relying on InstrumentationScope in SpanStub

rather than the deprecated InstrumentationLibrary
open-telemetry · Jul 17, 2024 · 813c485 · 813c485
1 parent e3892f0
commit 813c485
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 7 deletions.
diff --git a/exporters/otlp/otlptrace/otlptracegrpc/internal/otlptracetest/data.go b/exporters/otlp/otlptrace/otlptracegrpc/internal/otlptracetest/data.go
@@ -46,7 +46,7 @@ func SingleReadOnlySpan() []tracesdk.ReadOnlySpan {
 			DroppedLinks:      0,
 			ChildSpanCount:    0,
 			Resource:          resource.NewSchemaless(attribute.String("a", "b")),
-			InstrumentationLibrary: instrumentation.Library{
+			InstrumentationScope: instrumentation.Scope{
 				Name:    "bar",
 				Version: "0.0.0",
 			},

diff --git a/exporters/otlp/otlptrace/otlptracehttp/internal/otlptracetest/data.go b/exporters/otlp/otlptrace/otlptracehttp/internal/otlptracetest/data.go
@@ -46,7 +46,7 @@ func SingleReadOnlySpan() []tracesdk.ReadOnlySpan {
 			DroppedLinks:      0,
 			ChildSpanCount:    0,
 			Resource:          resource.NewSchemaless(attribute.String("a", "b")),
-			InstrumentationLibrary: instrumentation.Library{
+			InstrumentationScope: instrumentation.Scope{
 				Name:    "bar",
 				Version: "0.0.0",
 			},

diff --git a/exporters/zipkin/model_test.go b/exporters/zipkin/model_test.go
@@ -1015,15 +1015,15 @@ func TestTagsTransformation(t *testing.T) {
 		{
 			name: "instrLib-empty",
 			data: tracetest.SpanStub{
-				InstrumentationLibrary: instrumentation.Library{},
+				InstrumentationScope: instrumentation.Scope{},
 			},
 			want: nil,
 		},
 		{
 			name: "instrLib-noversion",
 			data: tracetest.SpanStub{
 				Attributes: []attribute.KeyValue{},
-				InstrumentationLibrary: instrumentation.Library{
+				InstrumentationScope: instrumentation.Scope{
 					Name: instrLibName,
 				},
 			},
@@ -1035,7 +1035,7 @@ func TestTagsTransformation(t *testing.T) {
 			name: "instrLib-with-version",
 			data: tracetest.SpanStub{
 				Attributes: []attribute.KeyValue{},
-				InstrumentationLibrary: instrumentation.Library{
+				InstrumentationScope: instrumentation.Scope{
 					Name:    instrLibName,
 					Version: instrLibVersion,
 				},

diff --git a/internal/shared/otlp/otlptrace/otlptracetest/data.go.tmpl b/internal/shared/otlp/otlptrace/otlptracetest/data.go.tmpl
@@ -46,7 +46,7 @@ func SingleReadOnlySpan() []tracesdk.ReadOnlySpan {
 			DroppedLinks:      0,
 			ChildSpanCount:    0,
 			Resource:          resource.NewSchemaless(attribute.String("a", "b")),
-			InstrumentationLibrary: instrumentation.Library{
+			InstrumentationScope: instrumentation.Scope{
 				Name:    "bar",
 				Version: "0.0.0",
 			},

diff --git a/sdk/trace/tracetest/span.go b/sdk/trace/tracetest/span.go
@@ -60,6 +60,7 @@ type SpanStub struct {
 	DroppedLinks           int
 	ChildSpanCount         int
 	Resource               *resource.Resource
+	InstrumentationScope   instrumentation.Scope
 	InstrumentationLibrary instrumentation.Library
 }
 
@@ -85,12 +86,18 @@ func SpanStubFromReadOnlySpan(ro tracesdk.ReadOnlySpan) SpanStub {
 		DroppedLinks:           ro.DroppedLinks(),
 		ChildSpanCount:         ro.ChildSpanCount(),
 		Resource:               ro.Resource(),
+		InstrumentationScope:   ro.InstrumentationScope(),
 		InstrumentationLibrary: ro.InstrumentationScope(),
 	}
 }
 
 // Snapshot returns a read-only copy of the SpanStub.
 func (s SpanStub) Snapshot() tracesdk.ReadOnlySpan {
+	scopeOrLibrary := s.InstrumentationScope
+	if scopeOrLibrary.Name == "" && scopeOrLibrary.Version == "" && scopeOrLibrary.SchemaURL == "" {
+		scopeOrLibrary = s.InstrumentationLibrary
+	}
+
 	return spanSnapshot{
 		name:                 s.Name,
 		spanContext:          s.SpanContext,
@@ -107,7 +114,7 @@ func (s SpanStub) Snapshot() tracesdk.ReadOnlySpan {
 		droppedLinks:         s.DroppedLinks,
 		childSpanCount:       s.ChildSpanCount,
 		resource:             s.Resource,
-		instrumentationScope: s.InstrumentationLibrary,
+		instrumentationScope: scopeOrLibrary,
 	}
 }