Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate otelecho #5645

Merged
merged 4 commits into from
May 23, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

- The `go.opentelemetry.io/contrib/instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo` package is deprecated.
If you would like to become a Code Owner of this module and prevent it from being removed, see [#5551]. (#5598)
- The `go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho` package is deprecated.
If you would like to become a Code Owner of this module and prevent it from being removed, see [#5550]. (#5645)

[#5550]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5550
[#5551]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5551

## [1.27.0/0.52.0/0.21.0/0.7.0/0.2.0] - 2024-05-21
Expand Down
7 changes: 7 additions & 0 deletions instrumentation/github.com/labstack/echo/otelecho/doc.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,11 @@
//
// Currently only the routing of a received message can be instrumented. To do
// so, use the Middleware function.
//
// Deprecated: otelecho has no Code Owner.
// After August 21, 2024, it may no longer be supported and may stop
// receiving new releases unless a new Code Owner is found. See
// [this issue] if you would like to become the Code Owner of this module.
//
// [this issue]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5550
package otelecho // import "go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho"
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# labstack echo instrumentation example

:warning: Deprecated: otelaws has no Code Owner.
MrAlias marked this conversation as resolved.
Show resolved Hide resolved

An HTTP server using labstack echo and instrumentation. The server has a
`/users/:id` endpoint. The server generates span information to
`stdout`.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// Deprecated: otelecho has no Code Owner.
module go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho/example

go 1.21
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (

"github.com/labstack/echo/v4"

"go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho"
"go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho" // nolint:staticcheck // deprecated.
"go.opentelemetry.io/otel"
"go.opentelemetry.io/otel/attribute"
stdout "go.opentelemetry.io/otel/exporters/stdout/stdouttrace"
Expand Down
1 change: 1 addition & 0 deletions instrumentation/github.com/labstack/echo/otelecho/go.mod
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// Deprecated: otelecho has no Code Owner.
module go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho

go 1.21
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,12 @@ Package test validates the otelecho instrumentation with the default SDK.
This package is in a separate module from the instrumentation it tests to
isolate the dependency of the default SDK and not impose this as a transitive
dependency for users.

Deprecated: otelecho has no Code Owner.
After August 21, 2024, it may no longer be supported and may stop
receiving new releases unless a new Code Owner is found. See
[this issue] if you would like to become the Code Owner of this module.

[this issue]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5550
*/
package test // import "go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho/test"
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

"go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho"
"go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho" // nolint:staticcheck // deprecated.
"go.opentelemetry.io/otel"
"go.opentelemetry.io/otel/codes"
"go.opentelemetry.io/otel/sdk/trace"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// Deprecated: otelecho has no Code Owner.
module go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho/test

go 1.21
Expand Down