Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Move docker related files to examples folder #5640

Merged

Conversation

reyang
Copy link
Member

@reyang reyang commented May 21, 2024

Related to #5636 (comment).

@cijothomas and I had some discussion offline, these are something we might want to explore:

  1. Change the current ASP.NET Core 7.0 example to Aspire micro-service.
  2. Use the Aspire dashboard to show OTLP traffic (which covers logs/metrics/traces).
  3. Use Jaeger/Prometheus/OpenSearch/Grafana to demonstrate a vendor agnostic deployment (a mini version of the opentelemetry-demo).

@reyang reyang requested a review from a team as a code owner May 21, 2024 23:07
@reyang reyang changed the title Move docker related files to examples folder [docs] Move docker related files to examples folder May 22, 2024
@cijothomas
Copy link
Member

We need to update the readme (https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/examples/AspNetCore/README.md) to mention that there is a docker compose? Okay to do it separately, as the docker-compose file needs changes to install jaeger instead of tempo..
Don't think we want to block this PR.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need more works to make this useable for most users, but that come later. (I might be able to help make that change myself)

@CodeBlanch CodeBlanch merged commit 361a4b9 into open-telemetry:main May 23, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants