OpTestPstore.py:This patch checks for new files creation under /sys/fs/pstore #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
hegdevasant
reviewed
Apr 3, 2020
testcases/OpTestPstore.py
Outdated
| 1. Check Pstore is configured properly or not | ||
| 2. Trigger crash. | ||
| 3. Check new files are created or not under /sys/fs/pstore | ||
| 4. Enable FADUMP |
There was a problem hiding this comment.
Why are you doing this in pstore test case path?
testcases/OpTestPstore.py
Outdated
| # | ||
| # OpenPOWER Automated Test Project | ||
| # | ||
| # Contributors Listed Below - COPYRIGHT 2017 |
testcases/OpTestPstore.py
Outdated
| res = self.con.run_command( "cat /boot/config-`uname -r` | grep -i --color=never 'CONFIG_PSTORE=y'") | ||
| print(res) | ||
| if(res[0]!='CONFIG_PSTORE=y'): | ||
| self.fail("PSTORE is not configured") |
testcases/OpTestPstore.py
Outdated
| self.con = self.cv_SYSTEM.console | ||
| self.c = self.cv_SYSTEM.cv_HOST.get_ssh_connection() | ||
|
|
||
| def pstore_check(self): |
testcases/OpTestPstore.py
Outdated
|
|
||
| def kernel_crash(self): | ||
| #1. This function will trigger a Crash | ||
| #2. Check for lpar or baremetal |
There was a problem hiding this comment.
Probably you should check this before crashing (may be as part of setup).
testcases/OpTestPstore.py
Outdated
| else: | ||
| print("New file %s is not created" % i) | ||
|
|
||
| def setup_fadump(self): |
There was a problem hiding this comment.
I don't think fadump stuff should be included in this file.
| print("Fadump service is not configured properly") | ||
|
|
||
| class KernelCrash_Kdump(OpTestKernelBase): | ||
|
|
There was a problem hiding this comment.
Why kdump stuff is coming here. We already have multiple files/classes doing kdump/fadump stuff.
testcases/OpTestPstore.py
Outdated
| self.kernel_crash() | ||
|
|
||
|
|
||
| def crash_suite(): |
shirishaganta
force-pushed
the
pstore
branch
2 times, most recently
from
8994b3b to
074fd55
Compare
|
After addressing the above comments, Changed the testcase according to that |
…s/pstore After triggering crash with kdump, it checks for new files creation under /sys/fs/pstore Signed-off-by: shirisha Ganta <[email protected]>
PraveenPenguin
force-pushed
the
master
branch
2 times, most recently
from
4d0cb14 to
b976629
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After triggering crash with kdump it checks for
new files creation under /sys/fs/pstore
Signed-off-by: shirisha Ganta [email protected]