-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ratings: Encouraging more course ratings (fixes #6640) #7866
base: master
Are you sure you want to change the base?
Ratings: Encouraging more course ratings (fixes #6640) #7866
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So probably some question since I'm not sure if this is intended or not.
Trigger snack bar if course is not rated yet
Open Pop up on action click
- The snack bar for taking the course still appears even if I never joined the course (if you just click on a course then leave, it will still prompt the snack bar
trigger snack bar if course is completed
- I'm not sure how to see the snack bar if the course is completed? I only ever saw this snack bar (I tried to finish a course - by joining, and going to each steps with exams and stuff, but didn't see anything) -> unless you don't intended to have one since I only saw one snack bar code changes
Other than that, everything else works
@RheuX could you send a video of what is happening on your end? |
https://www.loom.com/share/c5ba17b15a274468b405a8fbe3ec25f8?sid=8f0a9bf1-adf9-4e14-82f1-75404055047d @Gavinp14 I think it's more of an edge case, i think i found it by accident also then i think it only happens for courses you join in the past, but not for courses you havent joined yet.
So to clarify, this will only happen if you joined a course in the past but now not enrolled - not sure if this is supposed to be fixed or not, since technically they even if you leave the course, it still saves your progress. I might say could you only prompt the snack bar if they finished with the course(?). If not then thats fine. For now ill just approve it since technically its not a bug, but it may be confusing if they haven't touch the course at all, but they just joined |
In the process of working on implementing a snack bar pop-up that appears if a learner has completed a course but not yet rated it. The snack bar pop-up will have an action button that will open a popup rating window that will let the learner rate the course. After learner has rated the course, the rating box will update.
Below is a checklist of what has been done and what still needs to be done.
fixes #6640