Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ratings: Encouraging more course ratings (fixes #6640) #7866

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Gavinp14
Copy link
Member

@Gavinp14 Gavinp14 commented Nov 29, 2024

In the process of working on implementing a snack bar pop-up that appears if a learner has completed a course but not yet rated it. The snack bar pop-up will have an action button that will open a popup rating window that will let the learner rate the course. After learner has rated the course, the rating box will update.
Below is a checklist of what has been done and what still needs to be done.
fixes #6640

  • trigger snack bar if course is completed
  • Trigger snack bar if course is not rated yet
  • Open Pop up on action click
  • add working popup functionality with comments and ratings.
  • Refactor code

@Gavinp14 Gavinp14 marked this pull request as ready for review December 4, 2024 17:53
Copy link
Member

@RheuX RheuX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So probably some question since I'm not sure if this is intended or not.

Trigger snack bar if course is not rated yet
Open Pop up on action click

  • The snack bar for taking the course still appears even if I never joined the course (if you just click on a course then leave, it will still prompt the snack bar

trigger snack bar if course is completed

  • I'm not sure how to see the snack bar if the course is completed? I only ever saw this snack bar (I tried to finish a course - by joining, and going to each steps with exams and stuff, but didn't see anything) -> unless you don't intended to have one since I only saw one snack bar code changes

image

Other than that, everything else works

@Gavinp14
Copy link
Member Author

Gavinp14 commented Dec 4, 2024

@RheuX could you send a video of what is happening on your end?

@RheuX
Copy link
Member

RheuX commented Dec 4, 2024

https://www.loom.com/share/c5ba17b15a274468b405a8fbe3ec25f8?sid=8f0a9bf1-adf9-4e14-82f1-75404055047d

@Gavinp14 I think it's more of an edge case, i think i found it by accident also then

i think it only happens for courses you join in the past, but not for courses you havent joined yet.

The snack bar for taking the course still appears even if I never joined the course (if you just click on a course then leave, it will still prompt the snack bar

So to clarify, this will only happen if you joined a course in the past but now not enrolled - not sure if this is supposed to be fixed or not, since technically they even if you leave the course, it still saves your progress. I might say could you only prompt the snack bar if they finished with the course(?). If not then thats fine.

For now ill just approve it since technically its not a bug, but it may be confusing if they haven't touch the course at all, but they just joined

@Gavinp14 Gavinp14 requested a review from Mutugiii December 4, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ratings: Encouraging more resource & course ratings
3 participants