Feature/of 459 improve contract tooling record facet deployments for each #148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds version information to Facets. A new script has been added to save this information to a new file.
Changes
Facets now have functions
facetVersion
andfacetName
to return the new hardcoded version information. Currently in case of changes in the contract this version information has to be updated manually.All facets versions is currently set to
"1.0.0"
New script
FacetVersions
queries all facets inRegistry
and stores version information in a new json file. We can not useProxy
andReadable
contracts to get all facets because Proxy contracts need to be initialized with the Registry address before we can callfacetAddresses()
function.To execute new script:
make facet-versions
New json follows same naming pattern than current "deployed" files:
<chain_id>[-staging].versions.json
Example:
Type of Change
Please check the boxes that apply to your pull request: