Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Rollouthandler #125

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Implement Rollouthandler #125

wants to merge 2 commits into from

Conversation

dhaiducek
Copy link
Member

@dhaiducek dhaiducek commented Aug 18, 2023 •
edited
Loading

@dhaiducek dhaiducek force-pushed the rollouthandler branch 2 times, most recently from 63f6038 to 9685a25 Compare August 25, 2023 19:55
@dhaiducek dhaiducek force-pushed the rollouthandler branch 5 times, most recently from a0d913c to 975d02d Compare December 19, 2023 16:35
@dhaiducek dhaiducek changed the title [WIP] Implement Rollouthandler Implement Rollouthandler Dec 19, 2023
@dhaiducek dhaiducek marked this pull request as ready for review January 15, 2024 14:56
@dhaiducek
Copy link
Member Author

/hold for reviews (I had forgotten/didn't check this was actually working 😄 )

It doesn't have a thorough set of E2E tests, but that's probably better handled as Integration tests where Placement is handling it rather than us manually patching Placement resources.

@dhaiducek dhaiducek requested a review from mprahl January 15, 2024 19:46
@dhaiducek dhaiducek force-pushed the rollouthandler branch 2 times, most recently from 6996d5c to 0011b7b Compare February 8, 2024 20:14
@yiraeChristineKim
Copy link
Contributor

@dhaiducek Could you ping me after the tests fixed? Thanks

yiraeChristineKim
yiraeChristineKim reviewed Feb 9, 2024
View reviewed changes
controllers/common/common.go
Namespace: namespace,
}

err := pd.c.List(context.TODO(), pdList, lopts)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this need context.TODO()? why not pass context?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good point. This List() function is buried inside of the placementDecisionLister interface, which should be implemented using a cache.Indexer instead of this List(), so I need to look into making that update..

@openshift-ci openshift-ci bot added the lgtm label Feb 22, 2024
@yiraeChristineKim yiraeChristineKim self-requested a review February 22, 2024 19:59
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, yiraeChristineKim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dhaiducek,yiraeChristineKim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiraeChristineKim yiraeChristineKim yiraeChristineKim approved these changes

@JustinKuli JustinKuli Awaiting requested review from JustinKuli

@mprahl mprahl Awaiting requested review from mprahl

Assignees

@yiraeChristineKim yiraeChristineKim

Labels
approved dco-signoff: yes do-not-merge/hold lgtm needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhaiducek @yiraeChristineKim @openshift-merge-robot