Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Improvements and Python 2.6 Support Dropped #126

Merged
merged 18 commits into from
Oct 28, 2017
Merged

Conversation

opalmer
Copy link
Owner

@opalmer opalmer commented Oct 28, 2017

This PR was created to get the build working again, replace old libraries and make other small improvements. A full list of changes can be found in changelog.rst. The most notable change introduced in this PR is in a4ea830

remove Python 2.6 from build

There are several dependencies which no longer support
Python 2.6 including the wheel library. Twisted itself
also no longer supports Python 2.6. Finally, official support
for the version ended back in 2013 and several major operating
systems do not use it as their default version.

At this time pywincffi still works with Python 2.6 but some of the libraries we depend on do not.

@opalmer opalmer added this to the 0.5.0 milestone Oct 28, 2017
@opalmer opalmer self-assigned this Oct 28, 2017
@codecov-io
Copy link

codecov-io commented Oct 28, 2017

Codecov Report

Merging #126 into master will not change coverage.
The diff coverage is 100%.

@opalmer
Copy link
Owner Author

opalmer commented Oct 28, 2017

@rodrigc please take a look. I was looking at #125/#124/#123/#122 and found the build was broken and needed some updates. I mainly wanted to run this PR by you to make sure dropping 2.6 would work for Twisted (last I recall, it should because the later versions no longer support 2.6?).

I have not had a chance yet to look into what's going to be required to support the functions you requested but this PR will have to merge first before I can start.

Some additional requests and questions for you:

  • Would you mind updating the issues you filed with examples in Twisted where the functions are being called? That can help write tests and would give me an idea of how those functions are currently being used.
  • Do you have a preference in terms of which of the issues you filed I should be looking into first?

@rodrigc
Copy link
Contributor

rodrigc commented Oct 28, 2017

Twisted 15.4.0 was the last version to support Python 2.6: https://github.com/twisted/twisted/blob/trunk/NEWS.rst#twisted-core-1540-2015-09-04

so if you want to drop Python 2.6 support, that is fine.

@rodrigc
Copy link
Contributor

rodrigc commented Oct 28, 2017

In terms of examples of the API's I mentioned, you can search the Twisted codebase for where they are used. They are in different classes in Twisted.

@opalmer opalmer merged commit d104331 into master Oct 28, 2017
@opalmer opalmer deleted the build-updates branch October 28, 2017 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants