Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unverified models to skip folder #651

Merged
merged 6 commits into from
Jan 30, 2024

Conversation

ramkrishna2910
Copy link
Contributor

This PR moves the models that were not successfully verified by the torch.export.verification API to a skip folder. These models will not be displayed on the Onnx Model Zoo webpage.

@ramkrishna2910 ramkrishna2910 self-assigned this Jan 29, 2024
@jcwchen
Copy link
Member

jcwchen commented Jan 29, 2024

LGTM. Just curious why these existing models cannot pass by their API? Are there any obvious reasons?

@ramkrishna2910
Copy link
Contributor Author

LGTM. Just curious why these existing models cannot pass by their API? Are there any obvious reasons?

Not sure yet. I will pass this on to the exporter team for further investigation.

@ramkrishna2910 ramkrishna2910 merged commit bec48b6 into main Jan 30, 2024
3 checks passed
@ramkrishna2910 ramkrishna2910 deleted the move_unverified_models_to_skip branch January 30, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants