This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @bschulte!
It may make sense to make this like the other case sensitive option, ie
string | boolean
such that it can besmart
/true
/false
.Then the check becomes something like this:
oni/browser/src/Services/Menu/MenuFilter.ts
Lines 25 to 39 in 262098f
That should also let you simplify the regex check like we have over here:
oni/browser/src/Services/QuickOpen/RegExFilter.ts
Lines 34 to 38 in afab2be
That lets us use the same regex for all three cases then.