package.json node version update (#263)

* updated version check script to use regex, updated package.json to require node version 16+

Co-authored-by: Daniel Cheng <[email protected]>

.ki-scripts/startup.js

@@ -192,12 +192,20 @@ pm2.connect(false, async function (err) {
  // ------------------------------------------------------------
  // ------------- CHECK FOR CORRECT NODE VERSION ---------------
 
- if (
- !process.version.split(".")[0].includes(pjson.engines.node.split(".")[0])
- ) {
+ const parseVersion = (nodeVersionString) => {
+ const majorVersion = nodeVersionString.split(".")[0];
+ const majorVersionIntOnly = majorVersion.replace(/[^0-9]/g,"");
+
+ return parseInt(majorVersionIntOnly);
+ }
+
+ const processNodeVersion = parseVersion(process.version)
+ const engineNodeRequirement = parseVersion(pjson.engines.node);
+
+ if (processNodeVersion < engineNodeRequirement) {
  spinner.warn(
  `This project requires Node version ${chalk.yellow(
- "16.x"
+ pjson.engines.node
  )} or higher. Please install Node.js and try again.${"\n"}`
  );
  pm2.disconnect();

.ki-scripts/version-check.js

@@ -2,13 +2,24 @@ import jetpack from "fs-jetpack";
 import chalk from "chalk";
 
 const pjson = jetpack.read("./package.json", "json");
+const parseVersion = (nodeVersionString) => {
+ const majorVersion = nodeVersionString.split(".")[0];
 
-if (!process.version.split(".")[0].includes(pjson.engines.node.split(".")[0])) {
+ // use regex to remove leading chars such as "v", "^", "<", ">", ""="
+ const majorVersionIntOnly = majorVersion.replace(/[^0-9]/g,"");
+
+ return parseInt(majorVersionIntOnly);
+}
+
+const processNodeVersion = parseVersion(process.version)
+const engineNodeRequirement = parseVersion(pjson.engines.node);
+
+if (processNodeVersion < engineNodeRequirement) {
  console.log(
  `This project requires Node version ${chalk.yellow(
  pjson.engines.node
  )} or higher. Please install Node.js and try again.${"\n"}`
  );
 
  process.exit(1);
-}
+}

package.json

@@ -47,6 +47,6 @@
  },
  "homepage": "https://github.com/onflow/kitty-items#readme",
  "engines": {
- "node": "16.x"
+ "node": ">=16.0.0"
  }
 }