Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several enhancements #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Several enhancements #11

wants to merge 3 commits into from

Conversation

ledzep2
Copy link

@ledzep2 ledzep2 commented Oct 8, 2014

  1. Remove isolated scope so it can work with other directives
  2. Add a asFile attribute to retrieve the file as a FileList object instead of dataurl
  3. Add a dropzoneEnabled attribute so the function can be disabled
  4. Set a default dropzoneHoverClass "file-dropping"

* Remove isolated scope so it can be attached to other directives.
@atticoos
Copy link
Member

atticoos commented Oct 8, 2014

Nice enhancement, for such a component, it would be nice to remove scope isolation.
Is this backwards compatible? It appears to be

@ledzep2
Copy link
Author

ledzep2 commented Oct 9, 2014

Yes. It's compatible. And there are two new attributes, asFile and dropzoneEnabled.

@brianmuse
Copy link
Member

This should maybe be a minor point release instead of a patch, since it adds new features. (see http://semver.org/)

@ledzep2
Copy link
Author

ledzep2 commented Oct 14, 2014

good point. any other comments?

zao.bi

On Tue, Oct 14, 2014 at 5:51 AM, Brian Muse [email protected]
wrote:

This should maybe be a minor point release instead of a patch, since it
adds new features. (see http://semver.org/)


Reply to this email directly or view it on GitHub
#11 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants