Do not create export register when Instance is saved #2760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creating a register if it does not exist when an Instance is saved resulted in some performance problems. This change ensures the only time we create a new register if it does not exist is when a CSV export is triggred
FrankApiyo
previously approved these changes
Jan 16, 2025
ukanga
previously approved these changes
Jan 16, 2025
kelvin-muchiri
dismissed stale reviews from ukanga and FrankApiyo
via
08ddc05
ukanga
previously approved these changes
Jan 16, 2025
FrankApiyo
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Creating a register if it does not exist when an Instance is saved resulted in a bloated queue and load on the database from traversing all submissions for a XForm.
Instances under which we should create the register:
Steps taken to verify this change does what is intended
Side effects of implementing this change
Prevents the queue and database from becoming bloated with requests to traverse all submissions for a form to build the export register when a Instance is saved.
Before submitting this PR for review, please make sure you have:
Closes #