Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage #86

Merged
merged 22 commits into from
Sep 23, 2024
Merged

Improve test coverage #86

merged 22 commits into from
Sep 23, 2024

Conversation

lincmba
Copy link
Contributor

@lincmba lincmba commented Sep 19, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Resolves #37

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for
    bug fixes
  • I have added documentation for any new feature(s) and configuration
    option(s) on the README.md
  • I have run mvn spotless:check to check my code follows the project's
    style guide
  • I have run mvn clean test jacoco:report to confirm the coverage report
    was generated at plugins/target/site/jacoco/index.html
  • I ran mvn clean package right before creating this pull request.

@lincmba lincmba force-pushed the improve_test_coverage branch from 0f9f1cc to a63493c Compare September 19, 2024 08:45
@lincmba lincmba marked this pull request as draft September 19, 2024 08:50
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.30%. Comparing base (e5c3ada) to head (138a2d4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main      #86       +/-   ##
=============================================
+ Coverage     44.25%   60.30%   +16.05%     
- Complexity      138      194       +56     
=============================================
  Files            16       16               
  Lines          1358     1358               
  Branches        160      160               
=============================================
+ Hits            601      819      +218     
+ Misses          689      460      -229     
- Partials         68       79       +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lincmba lincmba marked this pull request as ready for review September 20, 2024 11:27
@lincmba lincmba enabled auto-merge September 20, 2024 11:28
@lincmba lincmba force-pushed the improve_test_coverage branch from 45c5f1d to 138a2d4 Compare September 20, 2024 13:27
@lincmba lincmba merged commit 9a2ccc0 into main Sep 23, 2024
1 check passed
@lincmba lincmba deleted the improve_test_coverage branch September 23, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Test Coverage
4 participants