Welcome page

[jerembdn]

No description provided.

[AntoineKM]

Overall, i believe it could just be better to have a main app, also used to make the dashboard, with react router dom we could have a /welcome route instead of 10 react apps for a page, so it will reduce the extension build size, also adding pretty animations could improve the ux, and please commit using the following guidelines: https://docs.onruntime.com/contributing/commits

[AntoineKM]

it's true that I didn't do it everywhere, but get into the habit of using fallback colors when you use css variables

[jerembdn]

idk how to do it

[AntoineKM]

https://defensivecss.dev/tip/css-variable-fallback/

[AntoineKM]

don't use 100vh because we cant scroll if the window height is low

[jerembdn]

ok so i don't know how to do it

[AntoineKM]

in this file you just dont respect the sizes indicated on the figma

[jerembdn]

ahbon

[AntoineKM]

remove it

[jerembdn]

ça a vraiment rien à voir avec le dashboard

[AntoineKM]

yes, it's got nothing to do with the dashboard, but we're not going to make 10 react applications in a single extension, so we might as well combine everything in one application and put the dashboard, welcome and settings in it - the only thing that should be separate is the popup, because we can't do otherwise.

[jerembdn]

It could be added when the dashboard is made

[AntoineKM]

Or you can do it now so we can start the dashboard

[AntoineKM]

chrome.runtime.onInstalled.addListener((details) => {
  if (details.reason === 'install') {
    // code...
  }
});