Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

49984 Enhancement of the functionality - total price calculator #845

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

49984 Enhancement of the functionality - total price calculator #845

wants to merge 39 commits into from

Conversation

dai-eastgate
Copy link
Contributor

@dai-eastgate dai-eastgate commented Jun 28, 2024 •
edited
Loading

related to #843
changed log:

  • Added total price calculator feature
  • Added frontend display for total cost breakdown

@coveralls
Copy link

coveralls commented Jun 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9710741921

Details

  • 38 of 81 (46.91%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 79.31%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/EstateList.php 16 17 94.12%
plugin/Model/FormModelBuilder/FormModelBuilderEstateDetailSettings.php 18 19 94.74%
plugin/Field/CostsCalculator.php 0 41 0.0%
Totals Coverage Status
Change from base Build 9693965537: -0.3%
Covered Lines: 8368
Relevant Lines: 10551
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9711189634

Details

  • 78 of 81 (96.3%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 79.689%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/EstateList.php 16 17 94.12%
plugin/Field/CostsCalculator.php 40 41 97.56%
plugin/Model/FormModelBuilder/FormModelBuilderEstateDetailSettings.php 18 19 94.74%
Totals Coverage Status
Change from base Build 9693965537: 0.1%
Covered Lines: 8408
Relevant Lines: 10551
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9711461588

Details

  • 78 of 81 (96.3%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 79.689%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/EstateList.php 16 17 94.12%
plugin/Field/CostsCalculator.php 40 41 97.56%
plugin/Model/FormModelBuilder/FormModelBuilderEstateDetailSettings.php 18 19 94.74%
Totals Coverage Status
Change from base Build 9693965537: 0.1%
Covered Lines: 8408
Relevant Lines: 10551
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9740059269

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 78 of 81 (96.3%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 79.689%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/EstateList.php 16 17 94.12%
plugin/Field/CostsCalculator.php 40 41 97.56%
plugin/Model/FormModelBuilder/FormModelBuilderEstateDetailSettings.php 18 19 94.74%
Totals Coverage Status
Change from base Build 9693965537: 0.1%
Covered Lines: 8408
Relevant Lines: 10551
💛 - Coveralls

@fredericalpers fredericalpers added this to the v4.25 milestone Jul 1, 2024
@fredericalpers fredericalpers added QA Issue or Pull request that is in review feature New feature component: property detail page Issue, Pull Request or Discussion related to property detail page labels Jul 1, 2024
@fredericalpers fredericalpers linked an issue Jul 1, 2024 that may be closed by this pull request
Enhancement of the functionality - total price calculator #843
Open
7 tasks
@fredericalpers fredericalpers added the deploy test Triggers event to create test version label Jul 26, 2024
@github-actions GitHub Actions
Copy link

Steps to install the approved version:

  1. Download onoffice-4.19-30-g3f66a0c1-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/10112214213.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@fredericalpers fredericalpers removed the deploy test Triggers event to create test version label Jul 26, 2024
@coveralls
Copy link

coveralls commented Jul 26, 2024 •
edited by github-actions bot
Loading

Pull Request Test Coverage Report for Build 10607650552

Details

  • 78 of 81 (96.3%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 78.418%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/EstateList.php 16 17 94.12%
plugin/Field/CostsCalculator.php 40 41 97.56%
plugin/Model/FormModelBuilder/FormModelBuilderEstateDetailSettings.php 18 19 94.74%
Totals Coverage Status
Change from base Build 10593215248: 0.1%
Covered Lines: 8557
Relevant Lines: 10912
💛 - Coveralls

@fredericalpers fredericalpers added the deploy test Triggers event to create test version label Jul 26, 2024
@github-actions GitHub Actions
Copy link

Steps to install the approved version:

  1. Download onoffice-4.20-20-geabb309b-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/10112338608.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@fredericalpers fredericalpers removed the deploy test Triggers event to create test version label Sep 30, 2024
@fredericalpers fredericalpers added the deploy test Triggers event to create test version label Sep 30, 2024
@miauzjpg
Copy link
Contributor

@dai-eastgate i changed a class name of a div and now the units tests not working. can you fix it? :'( cc75a86#diff-5e2d3b07808739c9754b8d996be05ce6e36470e13e18f327f7d00e0924a8c077L275

@dai-eastgate
Copy link
Contributor Author

@dai-eastgate i changed a class name of a div and now the units tests not working. can you fix it? :'( cc75a86#diff-5e2d3b07808739c9754b8d996be05ce6e36470e13e18f327f7d00e0924a8c077L275

@miauzjpg i will fix it

@miauzjpg
Copy link
Contributor

@dai-eastgate i changed a class name of a div and now the units tests not working. can you fix it? :'( cc75a86#diff-5e2d3b07808739c9754b8d996be05ce6e36470e13e18f327f7d00e0924a8c077L275

@miauzjpg i will fix it

thx!

@miauzjpg miauzjpg added deploy test Triggers event to create test version and removed deploy test Triggers event to create test version labels Nov 27, 2024
@github-actions GitHub Actions
Copy link

Steps to install the approved version:

  1. Download onoffice-5.2-41-gb6cdc165-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/12045787789.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@miauzjpg miauzjpg added deploy test Triggers event to create test version and removed deploy test Triggers event to create test version labels Dec 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

Steps to install the approved version:

  1. Download onoffice-5.2-44-g8f9ea95d-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/12175820498.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@fredericalpers fredericalpers modified the milestones: v5.3, v5.3.1 Dec 5, 2024
@miauzjpg miauzjpg added deploy test Triggers event to create test version and removed deploy test Triggers event to create test version labels Dec 20, 2024
@miauzjpg miauzjpg added deploy test Triggers event to create test version and removed deploy test Triggers event to create test version labels Dec 20, 2024
@github-actions GitHub Actions
Copy link

Steps to install the approved version:

  1. Download onoffice-5.3-52-gaa6325c8-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/12427585628.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@miauzjpg miauzjpg added deploy test Triggers event to create test version and removed deploy test Triggers event to create test version labels Dec 23, 2024
@github-actions GitHub Actions
Copy link

Steps to install the approved version:

  1. Download onoffice-5.3-54-g4bc60ae0-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/12463974337.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: property detail page Issue, Pull Request or Discussion related to property detail page deploy test Triggers event to create test version feature New feature QA Issue or Pull request that is in review
Projects
None yet
Milestone
v5.3.1
Development

Successfully merging this pull request may close these issues.

Enhancement of the functionality - total price calculator
5 participants
@dai-eastgate @coveralls @fredericalpers @miauzjpg @yeneastgate