refactor: EditorController to access menu through IMainMenu API #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add IMainMenu#enableMenuItem API - Implement enableMenuItem methods - EditorContoller enable/disable menu item through the API Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
miurahr
commented
May 26, 2024
| * @param name a component name of menu item. | ||
| * @param enabled true when make it enabled, otherwise make it disabled. | ||
| */ | ||
| void enableMenuItem(String name, boolean enabled); |
There was a problem hiding this comment.
Now we have two type of menu manipulation interface.
getMenu(MenuKey)enableMenuItem(String name, boolean)
When we define name for all JMenu components, we can add getMenu(String name) for consistency.
There was a problem hiding this comment.
We can implement menu updates in Action class for these menu items.
The object can detect changes through ProperyChangeListener interface.
#983 will enable the strategy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to implement acceptance GUI test, it is important to decouple UI components from real main window object.
EditorController enable/disable some menu items through
mainwindow.menuaccess.This change decouple it.
To make things working, I add
IMainMenu#enableMenuItemAPI.This allow other components to enable/disable menu item like as
Core.getMainWindow().getMainMenu().enableMenuItem(name, true)Pull request type
refactor
Which ticket is resolved?
What does this PR change?
Other information