-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 16 support #892
React 16 support #892
Conversation
I don't know if this is ready to be merged yet. I'm tracking down what seems like missing externs, as our app is misbehaving with advanced compilation. |
Ok ready for this when you are. |
There's still an issue here, which breaks this line: Line 903 in bc1c30f
because React.createClass is not in React 16 anymore.
I didn't fix it because I was lazy. We can either fix it in another PR or bring in |
Other than that I fixed the needed externs issues |
Also need to fix some server-side rendering stuff. We don't need to generate checksums or React IDs anymore |
@anmonteiro can you plz explain why checksum/ids are not needed anymore ? |
@dupuchba from https://reactjs.org/blog/2017/09/26/react-v16.0.html
|
Is there a plan to create a new version containing it? |
|
This supersedes #883