Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support strings containing "from now" #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

j-sv
Copy link

@j-sv j-sv commented Oct 27, 2019

Adds support for one of the examples listed here.

Copy link
Owner

@olebedev olebedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested patch changes expected behavior fro deadlines from
strict (within|in) <point in time> for (within|in)? <point in time> (from now)?. This means that even a simple point in time will be treated as a deadline. I am not sure about the approach and still think that keep the rule as narrow as possible could save us from the unexpected indeterministic behavior of the parser.

I suggest implementing a rule like(simplified regexp):

((within|in)\s<point in time>)|(<point in time>\sfrom\now)

so it will be a narrower OR.

@j-sv
Copy link
Author

j-sv commented Oct 29, 2019

You're right, I hadn't considered that. I'll update it as you suggest.

@olebedev
Copy link
Owner

Hey @j-sv, just a friendly ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants