[pull] main from Shopify:main #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.18.2...4.19.2) --- updated-dependencies: - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [express](https://github.com/expressjs/express) from 4.18.1 to 4.19.2. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.18.1...4.19.2) --- updated-dependencies: - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 5.3.3 to 5.3.4. - [Release notes](https://github.com/webpack/webpack-dev-middleware/releases) - [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v5.3.4/CHANGELOG.md) - [Commits](webpack/webpack-dev-middleware@v5.3.3...v5.3.4) --- updated-dependencies: - dependency-name: webpack-dev-middleware dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: William Candillon <[email protected]>
removed unused import Image Co-authored-by: William Candillon <[email protected]>
Because the view is created after a drawing (SkPicture for instance), setting the picture would fail because no view info would be existing for that picture. Hence the drawing would go to wast
--------- Co-authored-by: William Candillon <[email protected]>
this upgrade is needed to get the correct types for the fiber reconciler.
this is a minor improvement to the package detection where a webpack config may not throw an exception for `require('react-native-reanimated')` but rather return an empty object instead.
This would be a breaking change but we realized that the reanimated 2 support was actually not working in recent versions
This is a new model where use a Picture recorder that supports animation values.
Consider the following deeply nested tree:
```jsx
<Image x={0} y={0} width={width} height={height} image={oslo} fit="cover">
<ColorMatrix matrix={matrix} />
<LinearToSRGBGamma>
<Lerp t={t}>
<ColorMatrix matrix={purple} />
<ColorMatrix matrix={blackAndWhite} />
</Lerp>
</LinearToSRGBGamma>
</Image>
```
This will generate the following instruction set:
```
[
{ type: 'SaveCTM', props: { transform: [Array] } },
{ type: 'SavePaint', props: {} },
{
type: 'PushColorFilter',
colorFilterType: 'skMatrixColorFilter',
props: { matrix: [Array] }
},
{
type: 'PushColorFilter',
colorFilterType: 'skMatrixColorFilter',
props: { matrix: [Array] }
},
{
type: 'PushColorFilter',
colorFilterType: 'skMatrixColorFilter',
props: { matrix: [Array] }
},
{
type: 'PushColorFilter',
colorFilterType: 'skLerpColorFilter',
props: { t: 0.5 }
},
{
type: 'PushColorFilter',
colorFilterType: 'skLinearToSRGBGammaColorFilter',
props: {}
},
{ type: 'ComposeColorFilter' },
{ type: 'MaterializePaint' },
{
type: 'DrawImage',
props: {
x: 0,
y: 0,
width: 256,
height: 256,
image: [JsiSkImage],
fit: 'cover'
}
},
{ type: 'RestorePaint' },
{ type: 'RestoreCTM' }
]
```
…seFont) (#2866) Hooks like useImage wrong manually dispose the data when unmounting even thought the reference might be still used somewhere else. In the case of the Skia reconciler, the image is disposed even before any kind of unmounting is signaled to the reconciler.
The number of prebuilt binaries Skia ships is getting increasingly bigger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )