Resolve issue #56. #175
Open
Resolve issue #56. #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ight associativity ambiguousness. Includes test to check change
pdubroy
reviewed
Nov 14, 2016
| ' | B\n' + | ||
| ' B = "117"\n' + | ||
| '}'); | ||
| t.fail('Expected an exception to be thrown'); |
There was a problem hiding this comment.
The more idiomatic way to ensure an exception is thrown is to use t.throws(): https://github.com/substack/tape#tthrowsfn-expected-msg
| // no-op | ||
| }; | ||
|
|
||
| pexprs.Alt.prototype.assertProperAssociativity = function(ruleName) { |
There was a problem hiding this comment.
You might as well just group all of the no-op versions together.
pdubroy
force-pushed
the
main
branch
4 times, most recently
from
ac91299
to
fdddc68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new error that fires on compile of left/right associativity ambiguousness. Includes test to check change.
Solution involves finding parent for the appropriate line, passing it in and making a check that verifies the case where there is a left/right associativity issue as per the issue #56.
I'm part of the UW group.