Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents duplicate events from merging with existing events. #341

Merged
merged 4 commits into from
Mar 6, 2024

Conversation

UdaySagar-Git
Copy link
Contributor

@UdaySagar-Git UdaySagar-Git commented Mar 5, 2024

fixes #324

  • Created a script for cleaning up existing data.
  • Prevents duplicate events from getting merged.

linked pr:
ohcnetwork/leaderboard-data#29

Copy link

vercel bot commented Mar 5, 2024

@UdaySagar-Git is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

@UdaySagar-Git
Copy link
Contributor Author

@rithviknishad can you please review

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@UdaySagar-Git Although this would work, just thought we could do it more cleanly.

  1. Let's use fs/promises and async/awaits instead and parallelize by wrapping the job in a Promise.all for each contributor.
  2. We could ensure uniqueness using Object.values(Object.fromEntries(...)) approach in a more cleaner way.
image

@UdaySagar-Git
Copy link
Contributor Author

Sure will update shortly

@UdaySagar-Git
Copy link
Contributor Author

@rithviknishad updated and re ran script for confirmation

@rithviknishad rithviknishad merged commit 56af2a5 into ohcnetwork:main Mar 6, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple duplicate review events captured by scraper
2 participants