Fix Conditional Rendering of TextAreaFormField for Sample Test Type #8960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JavidSumra
changed the title
rithviknishad
requested changes
Oct 29, 2024
|
@rithviknishad Can I add extra space after type for that or just display it inline? |
|
you can add it to the right (2nd col. of the grid) like others |
|
@rithviknishad requested changes done |
Jacobjeevan
requested changes
Oct 29, 2024
| @@ -25,6 +25,7 @@ export const SampleDetails = ({ id }: DetailRoute) => { | |||
| if (!(res?.ok && data)) { | |||
| navigate("/not-found"); | |||
| } | |||
| console.log(data); | |||
There was a problem hiding this comment.
Let's remove this console.log 👍
| {sampleDetails?.sample_type === "OTHER TYPE" && ( | ||
| <div> | ||
| <span className="font-semibold capitalize leading-relaxed"> | ||
| Sample Type Description: |
There was a problem hiding this comment.
Add a space after the colon, similar to what's there for other titles.
On a side note, now's probably the time to add in translations for these titles.
There was a problem hiding this comment.
So shall I need to add translation for each field title?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
TextAreaFormFieldon "OTHER TYPE" selections in the sample type dropdown.@ohcnetwork/care-fe-code-reviewers
Merge Checklist