Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: TypeError in notification list #8935

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

AdityaJ2305
Copy link
Contributor

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Request for Peer Reviews

Note

I noticed there was an existing PR addressing this issue, but it seems inactive with unresolved conflicts. I’ve resolved the issue here to help move things forward.

Copy link

netlify bot commented Oct 27, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 5c577ef
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6721416d76a3eb00099f3ab3
😎 Deploy Preview https://deploy-preview-8935--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AdityaJ2305 AdityaJ2305 marked this pull request as ready for review October 27, 2024 07:20
@AdityaJ2305 AdityaJ2305 requested a review from a team as a code owner October 27, 2024 07:20
@bodhish
Copy link
Member

bodhish commented Oct 27, 2024

@AdityaJ2305 we would really try to merge the 1st PR for any issue, unless its super inactive for long.

Note to Reviewers: See if we can savage #8686, if we are going ahead with #8935 close the other and let the author know the reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError in NotificationsList Component on Service Worker Subscription Fetch
2 participants