Adding of clear and cancel button in create preset form #8921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shivankacker
approved these changes
Oct 24, 2024
rithviknishad
approved these changes
Oct 25, 2024
|
|
||
| <div className="cui-form-button-group mt-4 flex w-full flex-col justify-end space-y-2 sm:flex-row sm:space-x-2 sm:space-y-0"> | ||
| <Cancel | ||
| shadow={false} |
There was a problem hiding this comment.
Suggested change
| shadow={false} |
There was a problem hiding this comment.
Done the changes. I thought to maintain a simpler and cleaner design.
|
@rithviknishad Can you please assign 2 story points for this |
|
@Rishith25 for minor changes we keep it to 1. |
|
|
|
@nihal467 Done the changes of clear button alignment |
| /> | ||
| </div> | ||
|
|
||
| <div className="cui-form-button-group mt-4 flex w-full flex-col justify-end space-y-2 sm:flex-row sm:space-x-2 sm:space-y-0"> |
There was a problem hiding this comment.
Suggested change
| <div className="cui-form-button-group mt-4 flex w-full flex-col justify-end space-y-2 sm:flex-row sm:space-x-2 sm:space-y-0"> | |
| <div className="cui-form-button-group"> |
| setCreatePreset(undefined); | ||
| setPresetName(""); | ||
| }} | ||
| className="ml-0 w-full sm:ml-2 sm:w-auto" |
There was a problem hiding this comment.
Suggested change
| className="ml-0 w-full sm:ml-2 sm:w-auto" |
| @@ -417,6 +429,7 @@ export default function ConfigureCamera(props: Props) { | |||
| cameraPresetsQuery.refetch(); | |||
| }} | |||
| disabled={!presetName} | |||
| className="w-full sm:w-auto" | |||
There was a problem hiding this comment.
Suggested change
| className="w-full sm:w-auto" |
rithviknishad
requested changes
Oct 29, 2024
| @@ -35,30 +36,47 @@ const TextFormField = forwardRef((props: TextFormFieldProps, ref) => { | |||
| const hasTrailing = !!(trailing || trailingFocused); | |||
| const hasIcon = hasLeading || hasTrailing; | |||
| const [showPassword, setShowPassword] = useState(false); | |||
| const isClear = props.isClear || false; | |||
There was a problem hiding this comment.
null/undefined is falsey, it's no-op when used in conditional statements.
Suggested change
| const isClear = props.isClear || false; |
Comment on lines
392
to
403
| <div className="relative w-full"> | ||
| <TextFormField | ||
| name="preset-name" | ||
| className="w-full py-4" | ||
| value={presetName} | ||
| onChange={({ value }) => setPresetName(value)} | ||
| errorClassName="hidden" | ||
| placeholder={t("preset_name_placeholder")} | ||
| suggestions={presetNameSuggestions} | ||
| isClear={true} | ||
| /> | ||
| </div> |
There was a problem hiding this comment.
why wrap in a div with relative class here? is this needed?
| @@ -24,6 +24,7 @@ export type TextFormFieldProps = FormFieldBaseProps<string> & | |||
| trailingPadding?: string | undefined; | |||
| leadingPadding?: string | undefined; | |||
| suggestions?: string[]; | |||
| isClear?: boolean; | |||
There was a problem hiding this comment.
isClear doesn't make sense. One may not understand what this prop does by simply reading it.
Suggested change
| isClear?: boolean; | |
| clearable?: boolean; |
|
@rithviknishad Changes are done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist