Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed shifting details page responsiveness #8833

Conversation

modamaan
Copy link

@modamaan modamaan commented Oct 19, 2024

Proposed Changes

change the button alignment when phone size

Before
Screenshot 2024-10-20 000900

After
Screenshot 2024-10-20 011739

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@modamaan modamaan requested a review from a team as a code owner October 19, 2024 19:48
Copy link

netlify bot commented Oct 19, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit a7912a5
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/67140d8c3cf3cd00084d190b
😎 Deploy Preview https://deploy-preview-8833--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bodhish
Copy link
Member

bodhish commented Oct 21, 2024

@modamaan I think you should also fix the breadcrumbs. In mobile it should have a behaviour like this.
image

Its also fine if you have the same behavior in destop also.

https://ui.shadcn.com/docs/components/breadcrumb

@modamaan modamaan closed this by deleting the head repository Oct 21, 2024
@modamaan
Copy link
Author

I'm facing issues while trying to push to the repository again
Screenshot 2024-10-22 075203
@bodhish #8860

@bodhish
Copy link
Member

bodhish commented Oct 22, 2024

You need to push the commits to your fork;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

phone size responsive issue shifting details page
2 participants