Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discharged patients for stateAdmin facility page: consistent sort and advanced filters #8756

Closed
wants to merge 3 commits into from
Closed

Discharged patients for stateAdmin facility page: consistent sort and advanced filters #8756

wants to merge 3 commits into from

Conversation

Jacobjeevan
Copy link
Contributor

Proposed Changes

image
  • Modified Last Admitted to -> Admitted to
  • Added Review Missed
image
  • Added Facility and Facility Type
image

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Jacobjeevan Jacobjeevan requested a review from a team as a code owner October 10, 2024 07:59
@netlify Netlify
Copy link

netlify bot commented Oct 10, 2024 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 586b806
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/670c9e1e72fce400089e655d
😎 Deploy Preview https://deploy-preview-8756--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

👋 Hi, @Jacobjeevan,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 12, 2024
@Jacobjeevan Jacobjeevan removed the merge conflict pull requests with merge conflict label Oct 14, 2024
@nihal467
Copy link
Member

nihal467 commented Oct 14, 2024 •
edited
Loading

@Jacobjeevan As per The advanced filter and sort by options visible on the facility-specific discharge patient page should be the only options available in the advanced filters and sort by section when a state admin switches to the discharge patient list.

image

note: Only state admin accounts can view the entire discharge patient list across the state using this view,

@nihal467
Copy link
Member

nihal467 commented Oct 14, 2024 •
edited
Loading

Since the PR is not addressing the issue and as discussed in the EOD call, we are moving out state-admin specific activities, so reworking on the entire PR seems like a waste of effort, we can close the PR and related issue. @Jacobjeevan

@nihal467 nihal467 added question Further information is requested changes required and removed needs testing needs review labels Oct 14, 2024
@Jacobjeevan Jacobjeevan deleted the issues/8198-dischargedPatient-consistentSort branch October 14, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changes required question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the discharge patient list to have consistent sort by and advance filters
2 participants
@Jacobjeevan @nihal467