-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements to care config #8470 #8726
Enhancements to care config #8470 #8726
Conversation
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
New to this kind of Issues, so kindly let me know if there's something needed, or if there are mistakes. |
@Sulochan-khadka can you please fix the failing cypress tests |
i have fixed all cypress tests but dont know why one is failing. May you help! |
Not sure if this is the right approach, i was thinking that we would add some sort of json validator that would be run before the build step. 🤔 @rithviknishad please review the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not validate the env's during the build stage. That is the main requirement mentioned in the issue.
We could add a script and call that script (that imports care.config.ts
) before the vite build. If validation fails, exit with a non-zero status code so that vite build does not start (as vite build should happen only after the validation script runs).
Yes; you are right |
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist