Allows configuring available languages through env and adds Hindi to CARE #8692

shivankacker · 2024-10-02T19:55:23Z

Proposed Changes

Adds a new availableLocales variable in care config, derived from the REACT_AVAILABLE_LOCALES variable.
Added example env

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

…CARE

netlify · 2024-10-02T19:55:44Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`3547988`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/66ff8ce71881ed00080f7bff
😎 Deploy Preview	https://deploy-preview-8692--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cloudflare-workers-and-pages · 2024-10-02T19:55:53Z

Deploying care-fe with Cloudflare Pages

Latest commit:	`3547988`
Status:	✅ Deploy successful!
Preview URL:	https://b4895d33.care-fe.pages.dev
Branch Preview URL:	https://add-hindi.care-fe.pages.dev

View logs

cypress · 2024-10-02T20:03:32Z

CARE Run #3530

Run Properties: Failed #3530 • 3547988dad: Allows configuring available languages through env and adds Hindi to CARE

Project	`CARE`
Branch Review	`add-hindi`
Run status	`Failed #3530`
Run duration	`05m 53s`
Commit	`3547988dad: Allows configuring available languages through env and adds Hindi to CARE`
Committer	`Shivank Kacker`
View all properties for this run ↗︎

Test results
Failures	`1`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`123`
View all changes introduced in this branch ↗︎

Tests for review

cypress/e2e/patient_spec/PatientBedManagement.cy.ts • 1 failed test • UI-Chrome

View Output

Test		Artifacts
Patient swtich bed functionality > Assign a bed for a admitted patient from update consultation page		`Test Replay` `Screenshots`

bodhish · 2024-10-02T21:45:23Z

.env

@@ -12,3 +12,4 @@ REACT_CARE_API_URL=https://careapi.ohc.network
 # Dev envs
 ESLINT_NO_DEV_ERRORS=true
 CARE_CDN_URL="https://egov-s3-facility-10bedicu.s3.amazonaws.com https://egov-s3-patient-data-10bedicu.s3.amazonaws.com http://localhost:4566"
+REACT_AVAILABLE_LOCALES="EN,HI,TA,ML,MR,KN"


should we pick small case? 🤔

wouldn't 'ALLOWED_LOCALES' term be more appropriate?

Agreed @rithviknishad

bodhish · 2024-10-02T22:45:18Z

care.config.ts

@@ -38,6 +38,9 @@ const careConfig = {
 customLogo: logo(env.REACT_CUSTOM_LOGO),
 customLogoAlt: logo(env.REACT_CUSTOM_LOGO_ALT),
 customDescription: env.REACT_CUSTOM_DESCRIPTION,
+ availableLocales: (env.REACT_AVAILABLE_LOCALES || "")
+ .split(",")
+ .map((l) => l.trim().toLowerCase()),


Suggested change

.map((l) => l.trim().toLowerCase()),

.map((l) => l.trim()),

@bodhish this is to be sure that random case characters in the ENV don't break things.

Lets not have it, env configuration is one time and validation for the env will take care of it. #8470

bodhish · 2024-10-02T22:46:35Z

src/Locale/hi/index.js

@@ -0,0 +1,45 @@
+import Asset from "./Asset.json";


Do we need this for all languages 🤔
Can't we write a dynamic import? ie all files in a folder 🤔

Updated. Using dynamic imports as much as possible now.

Update: Dynamic imports were causing issues during build due to their async nature. Reverted back.

I really don't want us to have this file for each language, not a priority to fix now but I think we should find a better solution for this.

We can take this up in a later issue. Tracking it through #8705

bodhish · 2024-10-02T22:49:16Z

src/Components/Common/LanguageSelectorLogin.tsx

+ const availableLocales = Object.keys(LANGUAGE_NAMES).filter(
+ (l) => l === "en" || careConfig.availableLocales?.includes(l),
+ );


why do we need a special case for en?

So that even when there are no available languages set in env english is still there

I think its safe to assume that the env will configured correctly, we also have a default set, so I think we can ignore it

nihal467 · 2024-10-03T11:16:55Z

@shivankacker iam seeing commits and conversation going on, is it good for testing

shivankacker · 2024-10-03T11:44:32Z

@nihal467 waiting for @bodhish 's go ahead, but it is okay for testing

…o add-hindi

shivankacker · 2024-10-04T06:37:11Z

@nihal467 this is ready for testing

Allows configuring available languages through env and adds Hindi to …

6f8d62d

…CARE

shivankacker requested a review from a team as a code owner October 2, 2024 19:55

minor fix

346bcd5

shivankacker self-assigned this Oct 2, 2024

shivankacker added needs testing needs review labels Oct 2, 2024

bodhish requested changes Oct 2, 2024

View reviewed changes

Added dynamic imports and other changes

c230b1a

github-actions bot added the Deploy-Failed Deplyment is not showing preview label Oct 3, 2024

shivankacker requested a review from bodhish October 3, 2024 07:12

reverted dynamic imports

c468642

shivankacker removed the Deploy-Failed Deplyment is not showing preview label Oct 3, 2024

Merge branch 'develop' into add-hindi

dd808ee

nihal467 added the question Further information is requested label Oct 3, 2024

nihal467 removed the needs testing label Oct 3, 2024

shivankacker mentioned this pull request Oct 4, 2024

Find a better way to import translations for each language #8705

Open

shivankacker added 2 commits October 4, 2024 12:05

made changes

9b071b3

Merge branch 'add-hindi' of https://github.com/ohcnetwork/care_fe int…

3547988

…o add-hindi

shivankacker added needs testing and removed question Further information is requested labels Oct 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allows configuring available languages through env and adds Hindi to CARE #8692

Allows configuring available languages through env and adds Hindi to CARE #8692

shivankacker commented Oct 2, 2024

netlify bot commented Oct 2, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Oct 2, 2024 •

edited

Loading

cypress bot commented Oct 2, 2024 •

edited

Loading

bodhish Oct 2, 2024

rithviknishad Oct 3, 2024

bodhish Oct 3, 2024

bodhish Oct 2, 2024

shivankacker Oct 3, 2024

bodhish Oct 3, 2024

bodhish Oct 2, 2024

shivankacker Oct 3, 2024

shivankacker Oct 3, 2024

bodhish Oct 3, 2024

shivankacker Oct 4, 2024

bodhish Oct 2, 2024

shivankacker Oct 3, 2024

bodhish Oct 3, 2024

nihal467 commented Oct 3, 2024

shivankacker commented Oct 3, 2024

shivankacker commented Oct 4, 2024

Allows configuring available languages through env and adds Hindi to CARE #8692

Are you sure you want to change the base?

Allows configuring available languages through env and adds Hindi to CARE #8692

Conversation

shivankacker commented Oct 2, 2024

Proposed Changes

Merge Checklist

netlify bot commented Oct 2, 2024 • edited Loading

✅ Deploy Preview for care-ohc ready!

cloudflare-workers-and-pages bot commented Oct 2, 2024 • edited Loading

Deploying care-fe with Cloudflare Pages

cypress bot commented Oct 2, 2024 • edited Loading

Tests for review

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nihal467 commented Oct 3, 2024

shivankacker commented Oct 3, 2024

shivankacker commented Oct 4, 2024

netlify bot commented Oct 2, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Oct 2, 2024 •

edited

Loading

cypress bot commented Oct 2, 2024 •

edited

Loading