Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:Added units to Length and Width in Pressure Sore (#8209) #8678

Closed
wants to merge 3 commits into from
Closed

feat:Added units to Length and Width in Pressure Sore (#8209) #8678

wants to merge 3 commits into from

Conversation

noufalrahim
Copy link
Contributor

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@noufalrahim noufalrahim requested a review from a team as a code owner October 1, 2024 01:19
@netlify Netlify
Copy link

netlify bot commented Oct 1, 2024 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit ba60f9b
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/67009c96458b0f0008941488
😎 Deploy Preview https://deploy-preview-8678--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rithviknishad
rithviknishad requested changes Oct 1, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you keep the text in i18n locale files (for english locale is sufficient) and use that here using useTranslations?

@noufalrahim noufalrahim closed this Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad requested changes

Assignees
No one assigned
Labels
changes required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pressure sore : width and height units are missing
2 participants
@noufalrahim @rithviknishad