Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation README.md : Supported -browsers script #8528

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Update documentation README.md : Supported -browsers script #8528

merged 3 commits into from
Sep 13, 2024

Conversation

Zeshanxviii
Copy link
Contributor

@Zeshanxviii Zeshanxviii commented Sep 11, 2024 •
edited
Loading

Readme updated : supported-browsers script

Screenshot from 2024-09-11 20-02-19

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Zeshanxviii Zeshanxviii requested a review from a team as a code owner September 11, 2024 12:59
@netlify Netlify
Copy link

netlify bot commented Sep 11, 2024 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit a8e0159
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66e1a89ceeed290008a4594a
😎 Deploy Preview https://deploy-preview-8528--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad
Copy link
Member

rithviknishad commented Sep 11, 2024 •
edited
Loading

@Zeshanxviii PR title could be improved 😄

https://github.com/ohcnetwork/care_fe#contributing-to-care

@rithviknishad
Copy link
Member

@bodhish Should we consider auto-running the npm run supported-browsers in the npm run dev script?

@Zeshanxviii Zeshanxviii changed the title Issues/8527 Issues/8527/Update_reademe Sep 11, 2024
@rithviknishad
Copy link
Member

@Zeshanxviii You might have got confused with branch name and PR title. Checkout titles of other PRs.

@Zeshanxviii Zeshanxviii changed the title Issues/8527/Update_reademe Issues/8527/Update_readme Sep 11, 2024
@Zeshanxviii Zeshanxviii changed the title Issues/8527/Update_readme Update documentation README.md : Supported -browsers script Sep 11, 2024
@khavinshankar khavinshankar merged commit 8b678bf into ohcnetwork:develop Sep 13, 2024
32 of 33 checks passed
@github-actions GitHub Actions
Copy link

@Zeshanxviii Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update documentation for supported-browsers script
3 participants
@Zeshanxviii @rithviknishad @khavinshankar