Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated TreatmentSummary component by integrating it with PrintPreview Component #8430 #8441

Merged
merged 26 commits into from
Sep 18, 2024
Merged

Updated TreatmentSummary component by integrating it with PrintPreview Component #8430 #8441

merged 26 commits into from
Sep 18, 2024
+76 −87

Conversation

Zeshanxviii
Copy link
Contributor

@Zeshanxviii Zeshanxviii commented Aug 29, 2024 •
edited
Loading

Fixes [#8430 ]

Proposed Changes

  • Fixes Header and footer spacing in summaries #8430
  • Change 1
    Integrate Treatment summary component with printPreview component
  • Change 2
    added CSS to global style "CSS block ensures that when the PrintPreview component is printed, it has a clean, well-organized layout with proper spacing and separation of content, making it more suitable for a printed format."

@ohcnetwork/code-reviewers

printed treatmentSummary sample
NewtreatmentSUmmary.pdf

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Zeshanxviii Zeshanxviii requested a review from a team as a code owner August 29, 2024 18:55
@netlify Netlify
Copy link

netlify bot commented Aug 29, 2024 •
edited
Loading

👷 Deploy request for care-ohc pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 0bd4a57

@vercel Vercel
Copy link

vercel bot commented Aug 29, 2024

@Zeshanxviii is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

@vercel Vercel
Copy link

vercel bot commented Aug 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 11:52pm

rithviknishad
rithviknishad requested changes Aug 31, 2024
View reviewed changes
src/style/index.css Outdated Show resolved Hide resolved
src/style/index.css Outdated Show resolved Hide resolved
rithviknishad
rithviknishad reviewed Aug 31, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current changes LGTM.

Did you accidentally miss out on updating Investigations Summary too, it was mentioned in the issue?

@rithviknishad
Copy link
Member

You can see them in this route:

https://care.ohc.network/facility/0c95c7f0-e1d2-4aff-83fa-933cef60d3a8/patient/7e8fc20f-02da-47f7-8c33-f2d8c7e52dd8/consultation/edfe0bd6-0f50-4a4c-8cd0-2d4ad0e9cea1/investigation/e4759286-99a8-41a6-bc79-8628478b61d0

user: devdistrictadmin
pass: Coronasafe@123

rithviknishad
rithviknishad reviewed Sep 1, 2024
View reviewed changes
tailwind.config.js Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

👋 Hi, @Zeshanxviii,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Sep 3, 2024
@rithviknishad
Copy link
Member

rithviknishad commented Sep 3, 2024 •
edited
Loading

@Zeshanxviii could you redo for the treatment summary with the new version as it was updated in #8295

Zeshanxviii
Zeshanxviii commented Sep 3, 2024
View reviewed changes
Copy link
Contributor Author

@Zeshanxviii Zeshanxviii left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Sep 3, 2024
@rithviknishad rithviknishad removed merge conflict pull requests with merge conflict changes required labels Sep 11, 2024
rithviknishad
rithviknishad approved these changes Sep 11, 2024
View reviewed changes
src/Components/Common/PageTitle.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Sep 11, 2024
@rithviknishad rithviknishad removed the Deploy-Failed Deplyment is not showing preview label Sep 11, 2024
@Zeshanxviii Zeshanxviii deleted the issues/8430/fixingSpacing branch September 11, 2024 12:56
@Zeshanxviii Zeshanxviii restored the issues/8430/fixingSpacing branch September 11, 2024 12:56
@rithviknishad rithviknishad reopened this Sep 11, 2024
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit f7bda46 into ohcnetwork:develop Sep 18, 2024
17 of 19 checks passed
@github-actions GitHub Actions
Copy link

@Zeshanxviii Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@shivankacker shivankacker shivankacker approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
needs review tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Header and footer spacing in summaries
6 participants
@Zeshanxviii @rithviknishad @nihal467 @shivankacker @khavinshankar @sainak