Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for "Still watching" prompt to prevent users from idling when watching stream #8440

Merged
merged 8 commits into from
Sep 4, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Aug 29, 2024

Proposed Changes

(Set a faster timeout in screen recording for demo purpose)

Screen.Recording.2024-08-29.at.19.23.31.mov

@ohcnetwork/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner August 29, 2024 13:55
Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 31, 2024 3:01am

Copy link

netlify bot commented Aug 29, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 86479c6
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66d75fd49451250008d0b393
😎 Deploy Preview https://deploy-preview-8440--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad
Copy link
Member Author

Adding i18n...

Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make the time configurable via env;

@rithviknishad
Copy link
Member Author

Let's make the time configurable via env;

How about through config.json instead? (All whitelablling envs are present there)

@rithviknishad
Copy link
Member Author

rithviknishad commented Aug 29, 2024

Also @bodhish the configuration should be for the base delay for the linear backoff right?

@bodhish
Copy link
Member

bodhish commented Aug 29, 2024

I'm not sure where we have kept the end, but let's keep it at a unified place.

Also set a sensible default, if the env is not present, the default should be taken

src/CAREUI/misc/RemainingTime.tsx Outdated Show resolved Hide resolved
@nihal467
Copy link
Member

nihal467 commented Sep 2, 2024

@rithviknishad the camera authentication frontend PR is buggy so keep this PR on hold since the camera feed is not working in develop

@rithviknishad
Copy link
Member Author

@nihal467 This can be tested without the feed being live. The still watching component wrapper is agnostic of where it's used. It just wraps over any component and observes for touches within that wrapped component.

@nihal467
Copy link
Member

nihal467 commented Sep 3, 2024

LGTM

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Sep 3, 2024
@rithviknishad rithviknishad requested review from bodhish and removed request for bodhish September 3, 2024 19:17
Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khavinshankar khavinshankar merged commit 4c61baa into develop Sep 4, 2024
34 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/feat/still-watching-stream branch September 4, 2024 04:39
Copy link

github-actions bot commented Sep 4, 2024

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Check to Ensure Users Are Actively Watching Camera Feeds
6 participants